fix for fish shell command concatenation #132
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed there is already a similar pull request #126, this is slightly more elegant as it checks for a partial match in the shell environment variable instead of assuming a fixed depth path. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fish shell the operator used to string subsequent commands together is not the same as bash. In bash it is
&&but in fish it is; and. This patch makes use of the$SHELLenvironment variable to check if fish is being used.I would prefer a method to check which shell vim is currently running in but had no luck and was forced to use the user's preferred shell. At least this will default to using the existing bash syntax and Fish shell users may set the
$SHELLenvironment variable if not set.